Messages in this thread | | | Date | Thu, 9 Aug 2012 09:31:28 +0100 | From | Catalin Marinas <> | Subject | Re: [PATCH 3/5] kmemleak: use rbtree instead of prio tree |
| |
On Wed, Aug 08, 2012 at 06:07:39PM +0100, Michel Lespinasse wrote: > kmemleak uses a tree where each node represents an allocated memory object > in order to quickly find out what object a given address is part of. > However, the objects don't overlap, so rbtrees are a better choice than > prio tree for this use. They are both faster and have lower memory overhead. > > Tested by booting a kernel with kmemleak enabled, loading the kmemleak_test > module, and looking for the expected messages. > > Signed-off-by: Michel Lespinasse <walken@google.com>
The patch looks fine to me but I'll give it a test later today and let you know.
-- Catalin
| |