Messages in this thread | | | Date | Wed, 8 Aug 2012 06:34:27 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 1/2] debugfs: Allow debugfs_create_dir() to take data |
| |
On Wed, Aug 08, 2012 at 09:24:32AM +0300, Hiroshi Doyu wrote: > Add __debugfs_create_dir(), which takes data passed from caller.
Why?
> Signed-off-by: Hiroshi Doyu <hdoyu@nvidia.com> > --- > fs/debugfs/inode.c | 7 ++++--- > include/linux/debugfs.h | 9 ++++++++- > 2 files changed, 12 insertions(+), 4 deletions(-) > > diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c > index 4733eab..423df9f 100644 > --- a/fs/debugfs/inode.c > +++ b/fs/debugfs/inode.c > @@ -387,7 +387,7 @@ struct dentry *debugfs_create_file(const char *name, umode_t mode, > EXPORT_SYMBOL_GPL(debugfs_create_file); > > /** > - * debugfs_create_dir - create a directory in the debugfs filesystem > + * __debugfs_create_dir - create a directory in the debugfs filesystem > * @name: a pointer to a string containing the name of the directory to > * create. > * @parent: a pointer to the parent dentry for this file. This should be a > @@ -404,10 +404,11 @@ EXPORT_SYMBOL_GPL(debugfs_create_file); > * If debugfs is not enabled in the kernel, the value -%ENODEV will be > * returned. > */ > -struct dentry *debugfs_create_dir(const char *name, struct dentry *parent) > +struct dentry *__debugfs_create_dir(const char *name, struct dentry *parent, > + void *data) > { > return __create_file(name, S_IFDIR | S_IRWXU | S_IRUGO | S_IXUGO, > - parent, NULL, NULL); > + parent, data, NULL); > } > EXPORT_SYMBOL_GPL(debugfs_create_dir);
You can't export a symbol that doesn't exist anymore.
What are you trying to do here? This patch doesn't look right at all.
greg k-h
| |