lkml.org 
[lkml]   [2012]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 02/41] TTY: 68328serial, fix compilation
On 08/08/2012 05:24 PM, Alan Cox wrote:
> On Tue, 7 Aug 2012 21:47:27 +0200
> Jiri Slaby <jslaby@suse.cz> wrote:
>
>> tty_struct->termios is no longer a pointer. This was changed recently
>> by "tty: move the termios object into the tty". But 68328serial was
>> not changed, so we now have a compilation error:
>> 68328serial.c: In function 'change_speed':
>> 68328serial.c:518:22: error: invalid type argument of '->' (have
>> 'struct ktermios') 68328serial.c: In function 'rs_set_ldisc':
>> 68328serial.c:620:31: error: invalid type argument of '->' (have
>> 'struct ktermios') 68328serial.c: In function 'rs_set_termios':
>> 68328serial.c:988:20: error: invalid type argument of '->' (have
>> 'struct ktermios')
>>
>> Fix that now.
>>
>> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
>> Cc: Alan Cox <alan@linux.intel.com>
>
> Cool - I couldn't even find a compile chain or config to test this. I'd
> assumed it was broken and really wanted dumping in staging (it still
> looks that way 8))

Heh, I cannot tell if there is any user at all. The only thing I know is
it used to compile cleanly the last time I tried and it became broken
now :).

BTW you perhaps know that, compilers for most arches are at:
ftp.kernel.org/pub/tools/crosstool/files/bin/

regards,
--
js
suse labs


\
 
 \ /
  Last update: 2012-08-08 22:21    [W:0.194 / U:0.532 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site