lkml.org 
[lkml]   [2012]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] pinctrl/nomadik: add ASIC DB8450 pinctrl driver
From
On Tue, Aug 7, 2012 at 10:26 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:

>> @@ -1722,6 +1722,8 @@ static int __devinit nmk_pinctrl_probe(struct platform_device *pdev)
>> /* Poke in other ASIC variants here */
>> if (version == PINCTRL_NMK_DB8500)
>> nmk_pinctrl_db8500_init(&npct->soc);
>> + if (platid->driver_data == PINCTRL_NMK_DB8540)
>> + nmk_pinctrl_db8540_init(&npct->soc);
>
> I'm surprised one of those checks "version" and the other
> "platid->driver_data".
>
> Aside from that, this looks fine.

Bah, I'll fix this, then add your ACK.

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2012-08-08 11:22    [W:0.339 / U:0.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site