lkml.org 
[lkml]   [2012]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net:appletalk:ddp:fixed coding style issue again relating to
From
From: Jeffrin Jose <ahiliation@yahoo.co.in>
Date: Tue, 7 Aug 2012 19:30:20 +0530

> Fixed coding style issue relating to indentation in
> net/appletalk/ddp.c found by checkpatch.pl tool
>
> Signed-off-by: Jeffrin Jose <ahiliation@yahoo.co.in>

Please just stop trying to fix this code up, it's noise and you
keep making mistakes.

> case TIOCOUTQ: {
> - long amount = sk->sk_sndbuf - sk_wmem_alloc_get(sk);
> + long amount = sk->sk_sndbuf - sk_wmem_alloc_get(sk);
>
> - if (amount < 0)
> - amount = 0;
> - rc = put_user(amount, (int __user *)argp);
> - break;
> + if (amount < 0)
> + amount = 0;
> + rc = put_user(amount, (int __user *)argp);
> + break;
> }

This time you didn't adjust the closing brace, as needed.

I'm not applying this and I seriously discourage you from pursing this
further, it's better you spend your time learning how the kernel works
rather than suffering through this coding style cleanup business.

Thanks.


\
 
 \ /
  Last update: 2012-08-08 00:21    [W:0.043 / U:0.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site