Messages in this thread | | | Date | Tue, 7 Aug 2012 08:43:44 +0300 | From | Felipe Balbi <> | Subject | Re: [PATCH] driver: misc: bmp085: remove "of_match_table" property. |
| |
Hi,
On Mon, Aug 06, 2012 at 04:42:14PM +0100, Mark Brown wrote: > On Mon, Aug 06, 2012 at 12:30:34PM +0300, Felipe Balbi wrote: > > On Mon, Aug 06, 2012 at 02:58:44PM +0530, Sourav Poddar wrote: > > > There is an automatic binding done for I2C devices in the of_i2c core > > > code. So, DT will be able to bind to any I2C device using the > > > already existing table: MODULE_DEVICE_TABLE(i2c, bmp085_id). > > > Acked-by: Felipe Balbi <balbi@ti.com> > > It's good practice to have an explict compatible string even if the > default happens to work in order to avoid any name clashes.
of_i2c.c makes no use whatsoever of the compatible string. See that it will build an i2c_boardinfo and register a new device. That compatible string is just churn and has no use at all.
-- balbi [unhandled content-type:application/pgp-signature] | |