lkml.org 
[lkml]   [2012]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 52/70] USB: echi-dbgp: increase the controller wait time to come out of halt.
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Colin Ian King <colin.king@canonical.com>

    commit f96a4216e85050c0a9d41a41ecb0ae9d8e39b509 upstream.

    The default 10 microsecond delay for the controller to come out of
    halt in dbgp_ehci_startup is too short, so increase it to 1 millisecond.

    This is based on emperical testing on various USB debug ports on
    modern machines such as a Lenovo X220i and an Ivybridge development
    platform that needed to wait ~450-950 microseconds.

    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/usb/early/ehci-dbgp.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/early/ehci-dbgp.c b/drivers/usb/early/ehci-dbgp.c
    index 1fc8f12..347bb05 100644
    --- a/drivers/usb/early/ehci-dbgp.c
    +++ b/drivers/usb/early/ehci-dbgp.c
    @@ -450,7 +450,7 @@ static int dbgp_ehci_startup(void)
    writel(FLAG_CF, &ehci_regs->configured_flag);

    /* Wait until the controller is no longer halted */
    - loop = 10;
    + loop = 1000;
    do {
    status = readl(&ehci_regs->status);
    if (!(status & STS_HALT))



    \
     
     \ /
      Last update: 2012-08-07 06:44    [W:3.344 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site