lkml.org 
[lkml]   [2012]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] time: Fix adjustment cleanup bug in timekeeping_adjust()
On 08/04/2012 12:21 PM, Ingo Molnar wrote:
> * Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote:
>
>> Hello.
>>
>> Bisected to 2a8c0883 "time: Move xtime_nsec adjustment
>> underflow handling timekeeping_adjust".
>>
>> Would you check?
> probably caused by this stray return in timekeeping_adjust():
>
> } else
> return;
>
> which should really be a proper goto - like the (totally
> untested!) patch below.

Ooof. Your analysis looks correct, thanks for fixing this, Ingo!
And thanks for catching the issue Tetsuo!

thanks
-john



\
 
 \ /
  Last update: 2012-08-06 20:02    [from the cache]
©2003-2011 Jasper Spaans