Messages in this thread | | | Date | Mon, 6 Aug 2012 16:37:52 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 1/1] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots |
| |
On Mon, Aug 06, 2012 at 01:19:15AM -0700, Dmitry Torokhov wrote: > > - ponkey->irq_dbf = ab8500_irq_get_virq(ab8500, irq_dbf); > > - ponkey->irq_dbr = ab8500_irq_get_virq(ab8500, irq_dbr); > > + > > + ponkey->irq_dbf = (np) ? ab8500_irq_get_virq(ab8500, irq_dbf) : irq_dbf; > > + ponkey->irq_dbr = (np) ? ab8500_irq_get_virq(ab8500, irq_dbr) : irq_dbr; > > Why this isn't done inside ab8500_irq_get_virq()?
There's no reason why it can't be.
My first version of the patch did just that in fact.
Would that be your preference?
-- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |