Messages in this thread | | | From | "Kim, Milo" <> | Subject | RE: [PATCH] lp8727_charger: use IRQF_ONESHOT | Date | Thu, 30 Aug 2012 11:41:54 +0000 |
| |
> > ERROR: Threaded IRQ with no primary handler requested without > > IRQF_ONESHOT > > > > Make sure threaded IRQs without a primary handler are always request > > with IRQF_ONESHOT > > > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > > --- > > > > Note: I don't really know much about the situation, feel free to > > ignore it if it's an false warning. > > > > cocci-output-25411-2ae2e0-lp8727_charger.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > --- a/drivers/power/lp8727_charger.c > > +++ b/drivers/power/lp8727_charger.c > > @@ -255,7 +255,7 @@ static int lp8727_intr_config(struct lp8 > > return request_threaded_irq(pchg->client->irq, > > NULL, > > lp8727_isr_func, > > - IRQF_TRIGGER_FALLING, > > + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, > > "lp8727_irq", > > pchg); > > } > Thanks for the update. > > Acked-by: Milo(Woogyom) Kim <milo.kim@ti.com> >
Please refer to the patch below. [PATCH 4/8] lp8727_charger: cleanup the interrupt handler code This includes previous Fengguang' patch.
Best Regards, Milo
| |