Messages in this thread | | | Date | Thu, 30 Aug 2012 16:01:29 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH v2] drivers/tty: Folding Android's keyreset driver in sysRQ |
| |
Hi Matthieu,
On Thu, Aug 30, 2012 at 04:30:54PM -0600, mathieu.poirier@linaro.org wrote: > From: "Mathieu J. Poirier" <mathieu.poirier@linaro.org> > > This patch adds keyreset functionality to the sysrq driver. It > allows certain button/key combinations to be used in order to > trigger device resets. > > The first time the key-combo is detected a work function that syncs > the filesystems is scheduled and the kernel rebooted. If all the keys > are released and then pressed again, it calls panic. Reboot on panic > should be set for this to work. A platform device that specify a > reset key-combo should be added to the board file to trigger the > feature.
Why do we need to involve a platform device and not use, for example, a module parameter, that could be set up from userspace?
Also, why do we need reset_fn() and not simply invoke SysRq-B handler that should call ctrl_alt_del() for us?
Thanks.
-- Dmitry
| |