lkml.org 
[lkml]   [2012]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] [PATCH] usbnet: code clean up using checkpatch
Date
On Thursday 30 August 2012 20:18:41 SeungGoo, Kim wrote:
> @@ -748,8 +752,9 @@ int usbnet_open (struct net_device *net)
> goto done_nopm;
> }
>
> - // put into "known safe" state
> - if (info->reset && (retval = info->reset (dev)) < 0) {
> + /* put into "known safe" state */
> + retval = info->reset(dev);
> + if (info->reset && retval < 0) {
> netif_info(dev, ifup, dev->net,
> "open reset fail (%d) usbnet usb-%s-%s, %s\n",

Dave,

please don't take this patch. It changes code and breaks the driver.
A great big NACK.

Kim,

please do not send coding style patches which change code.
As an exercise think about this piece of code.

Regards
Oliver





\
 
 \ /
  Last update: 2012-08-30 21:41    [W:0.096 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site