lkml.org 
[lkml]   [2012]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] lp8727_charger: use IRQF_ONESHOT
Date
> ERROR: Threaded IRQ with no primary handler requested without
> IRQF_ONESHOT
>
> Make sure threaded IRQs without a primary handler are always request
> with IRQF_ONESHOT
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>
> Note: I don't really know much about the situation, feel free to
> ignore it if it's an false warning.
>
> cocci-output-25411-2ae2e0-lp8727_charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/power/lp8727_charger.c
> +++ b/drivers/power/lp8727_charger.c
> @@ -255,7 +255,7 @@ static int lp8727_intr_config(struct lp8
> return request_threaded_irq(pchg->client->irq,
> NULL,
> lp8727_isr_func,
> - IRQF_TRIGGER_FALLING,
> + IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> "lp8727_irq",
> pchg);
> }
Thanks for the update.

Acked-by: Milo(Woogyom) Kim <milo.kim@ti.com>

Best Regards,
Milo





\
 
 \ /
  Last update: 2012-08-29 04:41    [W:0.081 / U:1.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site