lkml.org 
[lkml]   [2012]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kmemleak: avoid buffer overrun: NUL-terminate strncpy-copied command
On Fri, Aug 24, 2012 at 01:23:29PM +0200, Jim Meyering wrote:
> In that case, what would you think of a patch to use strcpy instead?
>
> - strncpy(object->comm, current->comm, sizeof(object->comm));
> + strcpy(object->comm, current->comm);

Another option would be to use strlcpy(). It's slightly neater than
the strncpy() followed by a NUL assignment.

>
> Is there a preferred method of adding a static_assert-like statement?
> I see compile_time_assert and a few similar macros, but I haven't
> spotted anything that is used project-wide.

BUILD_BUG_ON().

regards,
dan carpenter



\
 
 \ /
  Last update: 2012-08-28 23:01    [W:0.066 / U:0.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site