lkml.org 
[lkml]   [2012]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [alsa-devel] [PATCH] ASoC: ams-delta: fix card initalization failure
Date
On Mon, 27 Aug 2012 14:38:35 Mark Brown wrote:
> On Mon, Aug 27, 2012 at 11:28:30PM +0200, Janusz Krzysztofik wrote:
>
> > - platform_set_drvdata(ams_delta_audio_platform_device,
> > - &ams_delta_audio_card);
> > -
> > - ret = platform_device_add(ams_delta_audio_platform_device);
> > - if (ret)
> > - goto err;
>
> The real fix here is that you should be using platform data here, not
> driver data. Is there some reason not to do that?

Mark,

Do you think the change you propose is suitable for the rc cycle? I'm
trying to fix a regression in the first place. Converting the ams-delta
asoc to a platform driver is on my todo list and I'm going to take care
of this as soon as I have enough spare time.

Thanks,
Janusz



\
 
 \ /
  Last update: 2012-08-28 18:01    [W:0.070 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site