lkml.org 
[lkml]   [2012]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] NFS: Fix Oopses in nfs_lookup_revalidate and nfs4_lookup_revalidate
From
Date
On Mon, 2012-08-27 at 20:16 +0000, Myklebust, Trond wrote:
> On Mon, 2012-08-27 at 13:09 -0700, Greg KH wrote:
> > On Wed, Aug 22, 2012 at 04:08:17PM -0400, Trond Myklebust wrote:
> > > Fix the following Oops in 3.5.1:
[...]
> > > This Oops affects 3.5 kernels and older, and is due to lookup_one_len()
> > > calling down to the dentry revalidation code with a NULL pointer
> > > to struct nameidata.
> > >
> > > It is fixed upstream by commit 0b728e1911c (stop passing nameidata *
> > > to ->d_revalidate())
> >
> > So this is just a nfs-only backport of the larger patch 0b728e1911c,
> > right? Should we also do this for other filesystems as well? Or just
> > backport the whole commit?
>
> The larger patch involves a VFS api change (the atomic open code) which
> has a bunch of pre- and post-requirements. I'd assume that is a too
> large change for stable. I think that the smaller per-filesystem changes
> are probably more appropriate. The list of filesystems that care are
> likely to be small. Off the top of my head, I can only think of NFS,
> CIFS, FUSE and possibly ceph.

What is the earliest version that needs this fix?

Ben.

--
Ben Hutchings
One of the nice things about standards is that there are so many of them.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-08-28 00:01    [W:0.486 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site