lkml.org 
[lkml]   [2012]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 12/19] x86, irq: Add data structure to keep AMD specific irq remapping information
On Mon, Aug 20, 2012 at 03:55:58PM +0200, Joerg Roedel wrote:
> --- a/arch/x86/include/asm/hw_irq.h
> +++ b/arch/x86/include/asm/hw_irq.h
> @@ -101,6 +101,7 @@ static inline void set_io_apic_irq_attr(struct io_apic_irq_attr *irq_attr,
> irq_attr->polarity = polarity;
> }
>
> +/* Intel specific interrupt remapping information */
> struct irq_2_iommu {
> struct intel_iommu *iommu;
> u16 irte_index;
> @@ -108,6 +109,12 @@ struct irq_2_iommu {
> u8 irte_mask;
> };
>
> +/* AMD specific interrupt remapping information */
> +struct irq_2_irte {
> + u16 devid; /* Device ID for IRTE table */
> + u16 index; /* Index into IRTE table*/
> +};
so irte_index like in iommu case would make the comment superfluous. However
the struct is already named _irte...
However, the "{Intel|AMD} specific..." is helpfull since irte and such are
present in both.

Sebastian


\
 
 \ /
  Last update: 2012-08-26 21:01    [W:0.171 / U:5.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site