lkml.org 
[lkml]   [2012]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 2/2] powerpc: Uprobes port to powerpc
On Fri, Aug 24, 2012 at 05:07:31PM +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2012-08-24 at 11:13 +1000, Michael Ellerman wrote:
> >
> > Yeah. A NULL regs here is a kernel bug, so I think it's actually
> > preferable to crash than silently return.
>
> Or best, if you think there's a remote chance that the bug might hit:
>
> if (WARN(!regs))
> return

Incorporated this and other suggestions from Michael in v5 I just
posted.

Ananth



\
 
 \ /
  Last update: 2012-08-24 10:41    [W:0.346 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site