lkml.org 
[lkml]   [2012]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/14] aoe: for performance support larger packet payloads
    On Fri, 17 Aug 2012 21:18:37 -0400
    Ed Cashin <ecashin@coraid.com> wrote:

    > --- a/drivers/block/aoe/aoeblk.c
    > +++ b/drivers/block/aoe/aoeblk.c
    > @@ -279,6 +279,9 @@ aoeblk_gdalloc(void *vp)
    > if (bdi_init(&d->blkq->backing_dev_info))
    > goto err_blkq;
    > spin_lock_irqsave(&d->lock, flags);
    > + blk_queue_max_hw_sectors(d->blkq, BLK_DEF_MAX_SECTORS);
    > + d->blkq->backing_dev_info.ra_pages = BLK_DEF_MAX_SECTORS * 1024;
    > + d->blkq->backing_dev_info.ra_pages /= PAGE_CACHE_SIZE;

    This seems a bit abusive of BLK_DEF_MAX_SECTORS, which is in units of
    512-byte sectors. (BLK_DEF_MAX_SECTORS * 512)/PAGE_CACHE_SIZE would
    make sense.




    \
     
     \ /
      Last update: 2012-08-25 00:01    [W:4.094 / U:0.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site