lkml.org 
[lkml]   [2012]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/4] [RFC] ARM: treewide: manually change more mach-*/*.h includes
    On Thu, Aug 23, 2012 at 11:35:11AM +0000, Arnd Bergmann wrote:
    > About two third of the platform header files included in device drivers
    > are not related to platform_data according to what I found. Most of them
    > are also wrong (hardcoding interrupt numbers or addresses, headers
    > included by accident but not actually used, driver specific definitions
    > that don't belong in the platform, platform specific abstraction layers,
    > ...), but they tend to be harder to clean up.
    >
    > I hope we can get there eventually, but I think the intermediate step
    > of enforcing a mach-${MACH}/foo.h is a step in the right direction on
    > that way.

    I think the opposite: if a platform wishes to be part of the multiplatform
    kernel, it must clean up its header files first to become part of that,
    otherwise it will not be configured into such a kernel.

    Otherwise there's no incentive for platform maintainers to do anything
    other than sit around waiting for someone else to do it for them.
    There's also no incentive to avoid introducing new dependencies between
    drivers and mach/ include files in the future either.

    Yes, some platforms are going to need a lot more work than others to get
    them ready (such as the Samsung suite) but that doesn't mean that we
    should work around that, especially when the end-goal is to get rid of
    these platform dependencies between drivers and mach includes.


    \
     
     \ /
      Last update: 2012-08-24 23:21    [W:2.104 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site