lkml.org 
[lkml]   [2012]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/2] slub: correct the calculation of the number of cpu objects in get_partial_node
From
2012/8/25 Christoph Lameter <cl@linux.com>:
> On Sat, 25 Aug 2012, JoonSoo Kim wrote:
>
>> But, when using "cpu_partial_objects", I have a coding style problem.
>>
>> if (kmem_cache_debug(s)
>> || cpu_slab_objects + cpu_partial_objects
>> > s->max_cpu_object / 2)
>>
>> Do you have any good idea?
>
> Not sure what the problem is? The line wrap?

Yes! The line wrap.


if (kmem_cache_debug(s)
|| cpu_slab_objects + cpu_partial_objects >
s->max_cpu_object / 2)
break;

Above example use 82 columns... The line wrapping problem.

if (kmem_cache_debug(s) ||
cpu_slab_objects + cpu_partial_objects > s->max_cpu_object / 2)
break;

This one use 79 columns, but somehow ugly
because second line start at same column of above line.
Is it okay?


if (kmem_cache_debug(s)
|| cpu_slab_objects + cpu_partial_objects
> s->max_cpu_object / 2)
break;

Is it the best?
It use 72 columns.
Let me know what is the best method for this situation.

Thanks!


\
 
 \ /
  Last update: 2012-08-24 19:21    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog