[lkml]   [2012]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 02/19] [RFC] x86, apic: Mask IO-APIC and PIC unconditionally on LAPIC resume
On Mon, Aug 20, 2012 at 03:55:48PM +0200, Joerg Roedel wrote:
> IO-APIC and PIC use the same resume routines when IRQ
> remapping is enabled or disabled. So it should be safe to
> mask the other APICs for the IRQ-remapping-disabled case
> too.

So your point is that it works with irq-remapping so it should work without as
The lapic code registers its opcodes as the first syscore device so this code
is always executed before the lapic's and pic resume code. PIC masks its sources
during init so it does not matter if they are masked earlier. And ioapic, well
it restores its entries as well.
So yes, I think this safe to do here.


 \ /
  Last update: 2012-08-24 00:01    [W:0.223 / U:1.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site