lkml.org 
[lkml]   [2012]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] kconfig: replace 'oldnoconfig' with 'olddefconfig', what it really does
From
Date
Sorry for the late reply.

On Fri, 2012-08-17 at 15:16 +0800, Adam Lee wrote:
> As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, 'oldnoconfig' doesn't
> set new symbols to 'n', but instead sets it to their default values.
>
> So, this patch replace 'oldnoconfig' with 'olddefconfig', stop making
> people confused.
>
> PS: the document in conf.c fixed in another mail, "[PATCH] [Signed-off]
> kconfig: document oldnoconfig to what it really does in conf.c"

The reason that I didn't make this change myself is that I'm afraid that
things depend on 'oldnoconfig' existing. For example, ktest.pl has it
hardcoded. That may not be the only script that uses it.

I think a better solution would be to make oldnoconfig do just that, set
everything to 'n' as the name implies, and we can create a olddefconfig
to do what it does now.

-- Steve


>
> Signed-off-by: Adam Lee <adam8157@gmail.com>
> ---
> scripts/kconfig/Makefile | 6 +++---
> scripts/kconfig/conf.c | 18 +++++++++---------
> tools/testing/ktest/ktest.pl | 15 +++++++--------
> 3 files changed, 19 insertions(+), 20 deletions(-)
>




\
 
 \ /
  Last update: 2012-08-23 23:01    [W:0.059 / U:1.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site