lkml.org 
[lkml]   [2012]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 11/23] serial: omap: drop unnecessary check from remove
    Date
    if platform_get_drvdata() returns NULL, that's
    quite a nasty bug on the driver which we want to
    catch ASAP. Otherwise, that check is hugely
    unneeded.

    Tested-by: Shubhrajyoti D <shubhrajyoti@ti.com>
    Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
    Signed-off-by: Felipe Balbi <balbi@ti.com>
    ---
    drivers/tty/serial/omap-serial.c | 9 +++------
    1 file changed, 3 insertions(+), 6 deletions(-)

    diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
    index 9f709d4..9581741 100644
    --- a/drivers/tty/serial/omap-serial.c
    +++ b/drivers/tty/serial/omap-serial.c
    @@ -1336,13 +1336,10 @@ static int serial_omap_remove(struct platform_device *dev)
    {
    struct uart_omap_port *up = platform_get_drvdata(dev);

    - if (up) {
    - pm_runtime_disable(up->dev);
    - uart_remove_one_port(&serial_omap_reg, &up->port);
    - pm_qos_remove_request(&up->pm_qos_request);
    - }
    + pm_runtime_disable(up->dev);
    + uart_remove_one_port(&serial_omap_reg, &up->port);
    + pm_qos_remove_request(&up->pm_qos_request);

    - platform_set_drvdata(dev, NULL);
    return 0;
    }

    --
    1.7.12.rc3


    \
     
     \ /
      Last update: 2012-08-23 13:41    [W:2.712 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site