lkml.org 
[lkml]   [2012]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] tools lib traceevent: Modify header to work in C++ programs
Date
Hi, Steve

On Tue, 21 Aug 2012 19:13:20 -0400, Steven Rostedt wrote:
> tools lib traceevent: Modify header to work in C++ programs
>
> Replace keyword "private" from event-parse.h to allow it to be
> used in C++ programs.
>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
>
> diff --git a/tools/lib/traceevent/event-parse.h b/tools/lib/traceevent/event-parse.h
> index 5772ad8..c28713b 100644
> --- a/tools/lib/traceevent/event-parse.h
> +++ b/tools/lib/traceevent/event-parse.h
> @@ -49,7 +49,7 @@ struct pevent_record {
> int cpu;
> int ref_count;
> int locked; /* Do not free, even if ref_count is zero */
> - void *private;
> + void *r_private;

This r_ (and p_) prefix make it inconsistent with others. How about
simply using 'priv' instead?

Thanks,
Namhyung


> #if DEBUG_RECORD
> struct pevent_record *prev;
> struct pevent_record *next;
> @@ -106,7 +106,7 @@ struct plugin_option {
> char *plugin_alias;
> char *description;
> char *value;
> - void *private;
> + void *p_private;
> int set;
> };
>


\
 
 \ /
  Last update: 2012-08-22 09:41    [W:0.034 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site