| From | "Mingarelli, Thomas" <> | Subject | RE: [PATCH 38/74] lto, watchdog/hpwdt.c: Make assembler label global | Date | Wed, 22 Aug 2012 20:11:08 +0000 |
| |
I am OK with the changes. We have a few more coming soon to improve the kdump process when hpwdt is running. Just a heads up.
Thanks, Tom
-----Original Message----- From: wimvs@spo001.leaseweb.com [mailto:wimvs@spo001.leaseweb.com] On Behalf Of Wim Van Sebroeck Sent: Wednesday, August 22, 2012 2:25 PM To: Andi Kleen Cc: linux-kernel@vger.kernel.org; x86@kernel.org; mmarek@suse.cz; linux-kbuild@vger.kernel.org; JBeulich@suse.com; akpm@linux-foundation.org; Andi Kleen; Mingarelli, Thomas Subject: Re: [PATCH 38/74] lto, watchdog/hpwdt.c: Make assembler label global
Hi andi,
> From: Andi Kleen <ak@linux.intel.com> > > We cannot assume that the inline assembler code always ends up > in the same file as the original C file. So make any assembler labels > that are called with "extern" by C global > > Cc: wim@iguana.be > Signed-off-by: Andi Kleen <ak@linux.intel.com>
You have my signed-off-by, but I'm Cc-ing also the author of the driver (Tom Mingarelli) so that he is also aware of the proposed change.
Kind regards, Wim.
|