| Date | Wed, 22 Aug 2012 11:34:26 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH v6 03/13] block: Add bio_reset() |
| |
On Wed, Aug 22, 2012 at 10:04:00AM -0700, Kent Overstreet wrote: > Reusing bios is something that's been highly frowned upon in the past, > but driver code keeps doing it anyways. If it's going to happen anyways, > we should provide a generic method. > > This'll help with getting rid of bi_destructor - drivers/block/pktcdvd.c > was open coding it, by doing a bio_init() and resetting bi_destructor. > > v5: Add a define BIO_RESET_BITS, to be very explicit about what parts of > bio->bi_flags are saved. > v6: Further commenting verbosity, per Tejun > > Signed-off-by: Kent Overstreet <koverstreet@google.com> > CC: Jens Axboe <axboe@kernel.dk>
Given some users are converted later.
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
-- tejun
|