Messages in this thread |  | | Date | Wed, 22 Aug 2012 17:55:21 +0200 | | From | Oleg Nesterov <> | | Subject | Re: [PATCH v4 2/2] powerpc: Uprobes port to powerpc |
| |
On 08/22, Ananth N Mavinakayanahalli wrote: > > +int arch_uprobe_analyze_insn(struct arch_uprobe *auprobe, struct mm_struct *mm, unsigned long addr) > +{ > + unsigned int insn; > + > + if (addr & 0x03) > + return -EINVAL; > + > + memcpy(&insn, auprobe->insn, MAX_UINSN_BYTES); > + if (is_trap(insn)) > + return -ENOTSUPP;
This addresses the only concern I had, thanks.
Once again, I am in no position to review the powerpc code, but since I made some noise before: I think the patch is fine.
Oleg.
|  |