Messages in this thread | | | From | Chinmay V S <> | Date | Wed, 22 Aug 2012 14:14:55 +0530 | Subject | Re: [PATCH v2] lis3lv02d: Add STMicroelectronics lis331dlh digital accelerometer |
| |
Hi All,
A few nitpicks.
> + * LIS3331DLH spec says 1LSBs corresponds 4G/1024 -> 1LSB is 1000/1024 mG. > + * Sensitivity values for +/-2G, outdata in 12 bits for +/-2G scale. so 4 > + * bits adjustment is required Shouldn't it be "1LSB is 4000/1024 mG" ? Also "outdata in 12bits" (typo. in->is?)
On a more technical note, now that LIS3331DLH has 16bit resolution, why don't we simply return the entire 16-bit value in lis3lv02d_read_16(). The fact that lis3lv02d_read_16() has 16-bit resolution can be indicated by
@@ -954,6 +984,16 @@ int lis3lv02d_init_device(struct lis3lv02d *lis3) lis3->odr_mask = CTRL1_ODR0|CTRL1_ODR1|CTRL1_ODR2|CTRL1_ODR3; lis3->scale = LIS3_SENSITIVITY_8B; break; + case WAI_3DLH: + pr_info("16 bits 3DLH sensor found\n"); + lis3->read_data = lis3lv02d_read_16; + lis3->mdps_max_val = 32768; /* 16 bits for +/-2G */
-- regards CVS
| |