lkml.org 
[lkml]   [2012]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/core] perf symbols: Remove unneeded call to dso__set_long_name()
    Commit-ID:  261ee821c256dffa02e5608c7df51744a03992a2
    Gitweb: http://git.kernel.org/tip/261ee821c256dffa02e5608c7df51744a03992a2
    Author: Cody P Schafer <cody@linux.vnet.ibm.com>
    AuthorDate: Fri, 10 Aug 2012 15:22:52 -0700
    Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
    CommitDate: Mon, 13 Aug 2012 14:04:32 -0300

    perf symbols: Remove unneeded call to dso__set_long_name()

    dso__set_long_name() is already called by dso__load_vmlinux(), avoid
    calling it a second time unnecessarily.

    Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
    Cc: David Hansen <dave@linux.vnet.ibm.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Matt Hellsley <matthltc@us.ibm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
    Link: http://lkml.kernel.org/r/1344637382-22789-7-git-send-email-cody@linux.vnet.ibm.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/util/symbol.c | 4 +---
    1 files changed, 1 insertions(+), 3 deletions(-)

    diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
    index f02de8a..42c0d94 100644
    --- a/tools/perf/util/symbol.c
    +++ b/tools/perf/util/symbol.c
    @@ -1388,10 +1388,8 @@ int dso__load_vmlinux_path(struct dso *dso, struct map *map,
    filename = dso__build_id_filename(dso, NULL, 0);
    if (filename != NULL) {
    err = dso__load_vmlinux(dso, map, filename, filter);
    - if (err > 0) {
    - dso__set_long_name(dso, filename);
    + if (err > 0)
    goto out;
    - }
    free(filename);
    }


    \
     
     \ /
      Last update: 2012-08-21 19:01    [W:3.744 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site