Messages in this thread |  | | Date | Mon, 20 Aug 2012 19:46:09 +0000 | | From | Christoph Lameter <> | | Subject | Re: [PATCH 4/5] mempolicy: fix refcount leak in mpol_set_shared_policy() |
| |
On Mon, 20 Aug 2012, Mel Gorman wrote:
> @@ -2318,9 +2323,7 @@ void mpol_free_shared_policy(struct shared_policy *p) > while (next) { > n = rb_entry(next, struct sp_node, nd); > next = rb_next(&n->nd); > - rb_erase(&n->nd, &p->root);
Looks like we need to keep the above line? sp_delete does not remove the tree entry.
> - mpol_put(n->policy); > - kmem_cache_free(sn_cache, n); > + sp_delete(p, n); > } > mutex_unlock(&p->mutex); > } >
|  |