Messages in this thread Patch in this message | | | Date | Mon, 20 Aug 2012 15:47:48 -0400 (EDT) | From | Alan Stern <> | Subject | Re: [PATCH] USB: Build usb_speed_string unconditionally |
| |
On Mon, 20 Aug 2012, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com> > > The usb core uses usb_speed_string(). But it's only selected > for USB_GADGET. Enable it unconditionally.
What are you talking about? USB_COMMON isn't selected at all, but it does get built whenever USB or USB_GAGDET is enabled. From drivers/usb/Kconfig:
config USB_COMMON tristate default y depends on USB || USB_GADGET
One could argue that USB_COMMON should never be set to M, that it should be Y if either USB or USB_GADGET is enabled at all. But that's a separate matter.
> Fixes a lot of randconfig builds.
How?
Alan Stern
> Cc: greg@kroah.com > Signed-off-by: Andi Kleen <ak@linux.intel.com> > --- > drivers/usb/Makefile | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/Makefile b/drivers/usb/Makefile > index f5ed3d7..d74535b 100644 > --- a/drivers/usb/Makefile > +++ b/drivers/usb/Makefile > @@ -57,4 +57,4 @@ obj-$(CONFIG_USB_CHIPIDEA) += chipidea/ > obj-$(CONFIG_USB_RENESAS_USBHS) += renesas_usbhs/ > obj-$(CONFIG_USB_GADGET) += gadget/ > > -obj-$(CONFIG_USB_COMMON) += usb-common.o > +obj-y += usb-common.o
| |