lkml.org 
[lkml]   [2012]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drivers-core: beware dev_printk() from printing nonsense
From
Date
On Mon, 2012-08-20 at 18:53 +0200, Sebastian Andrzej Siewior wrote:
> On 08/20/2012 05:26 PM, Greg Kroah-Hartman wrote:
> >> skip:
> >> - if (level[3])
> >> + if (level[sizeof(KERN_ERR) - 1])
> >
> > This has already been fixed in my driver-core tree and will go to Linus
> > in a few hours.
>
> Ah. So I'm too late. Care to send a patch which replace [2] with the
> sizeof() operator like above?

Nope, the better fix is to use a different mechanism.

See commit acc8fa41ad31c5
("printk: add generic functions to find KERN_<LEVEL> headers")

and

commit 04d2c8c83d0e3a
("printk: convert the format for KERN_<LEVEL> to a 2 byte pattern")

I'll submit that "better fix" shortly after Greg's update has
been pulled/merged by Linus.

cheers, Joe



\
 
 \ /
  Last update: 2012-08-20 20:41    [W:0.373 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site