lkml.org 
[lkml]   [2012]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 16/19] HID: hid-multitouch: Remove misleading null test
    From
    Acked-by: Benjamin Tissoires <benjamin.tissoires@enac.fr>

    On Sun, Aug 12, 2012 at 11:42 PM, Henrik Rydberg <rydberg@euromail.se> wrote:
    > A null test was left behind during the autoloading work;
    > the test was introduced by 8d179a9e, but was never completely
    > reverted.
    >
    > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    > Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
    > ---
    > drivers/hid/hid-multitouch.c | 10 ++++------
    > 1 file changed, 4 insertions(+), 6 deletions(-)
    >
    > diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
    > index c400d90..b15133c 100644
    > --- a/drivers/hid/hid-multitouch.c
    > +++ b/drivers/hid/hid-multitouch.c
    > @@ -691,12 +691,10 @@ static int mt_probe(struct hid_device *hdev, const struct hid_device_id *id)
    > struct mt_device *td;
    > struct mt_class *mtclass = mt_classes; /* MT_CLS_DEFAULT */
    >
    > - if (id) {
    > - for (i = 0; mt_classes[i].name ; i++) {
    > - if (id->driver_data == mt_classes[i].name) {
    > - mtclass = &(mt_classes[i]);
    > - break;
    > - }
    > + for (i = 0; mt_classes[i].name ; i++) {
    > + if (id->driver_data == mt_classes[i].name) {
    > + mtclass = &(mt_classes[i]);
    > + break;
    > }
    > }
    >
    > --
    > 1.7.11.4
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-input" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html


    \
     
     \ /
      Last update: 2012-08-20 16:21    [W:3.306 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site