lkml.org 
[lkml]   [2012]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 46/74] x86, lto: Disable fancy hweight optimizations for LTO
On 08/19/2012 05:56 AM, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> The fancy x86 hweight uses different compiler options for the
> hweight file. This does not work with LTO. Just disable the optimization
> with LTO
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> arch/x86/Kconfig | 5 +++--
> arch/x86/include/asm/arch_hweight.h | 9 +++++++++
> 2 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 8ec3a1a..9382b09 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -224,8 +224,9 @@ config X86_32_LAZY_GS
>
> config ARCH_HWEIGHT_CFLAGS
> string
> - default "-fcall-saved-ecx -fcall-saved-edx" if X86_32
> - default "-fcall-saved-rdi -fcall-saved-rsi -fcall-saved-rdx -fcall-saved-rcx -fcall-saved-r8 -fcall-saved-r9 -fcall-saved-r10 -fcall-saved-r11" if X86_64
> + default "-fcall-saved-ecx -fcall-saved-edx" if X86_32 && !LTO
> + default "-fcall-saved-rdi -fcall-saved-rsi -fcall-saved-rdx -fcall-saved-rcx -fcall-saved-r8 -fcall-saved-r9 -fcall-saved-r10 -fcall-saved-r11" if X86_64 && !LTO
> + default "" if LTO
>

Seems heavy handed. How about using __attribute__((optimize(...))) instead?


--
error compiling committee.c: too many arguments to function


\
 
 \ /
  Last update: 2012-08-20 12:01    [W:0.284 / U:2.828 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site