Messages in this thread | | | From | Richard Genoud <> | Date | Mon, 20 Aug 2012 09:38:31 +0200 | Subject | Re: [PATCH 6/8] UBI: replace MTD_UBI_BEB_LIMIT with module parameter |
| |
2012/8/19 Shmulik Ladkani <shmulik.ladkani@gmail.com>: > Hi Richard, > > On Fri, 17 Aug 2012 16:35:22 +0200 Richard Genoud <richard.genoud@gmail.com> wrote: >> + "MTD devices may be specified by their number, name, or path to the MTD character device node.\n" >> + "Optional \"vid_hdr_offs\" parameter specifies UBI VID header position to be used by UBI. (default value if 0 or not set)\n" >> + "Optional \"max_beb_per1024\" parameter specifies the maximum expected bad eraseblock per 1024 eraseblocks. (default value (" >> + __stringify(CONFIG_MTD_UBI_BEB_LIMIT) ") if 0 or not set)\n" > > Looks like "mtd=/dev/mtd1,,25" is invalid, although we state "default > value if 0 or not set". I'm going to check that. > > Also, lines are exceeding 80 chars, not sure this is more readable than > if they were broken. Actually, I didn't split those lines to make checkpatch happy. Checkpatch.pl doesn't like split strings because they are hard to grep. So there's an exception on the 80 column rule for strings.
> > Regards, > Shmulik
-- for me, ck means con kolivas and not calvin klein... does it mean I'm a geek ?
| |