lkml.org 
[lkml]   [2012]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 1/4] xattr: extract simple_xattr code from tmpfs
On Thu, 16 Aug 2012, Tejun Heo wrote:
> On Thu, Aug 16, 2012 at 01:44:54PM -0400, aris@redhat.com wrote:
> > From: Li Zefan <lizefan@huawei.com>
> >
> > Extract in-memory xattr APIs from tmpfs. Will be used by cgroup.
> >
> > $ size vmlinux.o
> > text data bss dec hex filename
> > 4658782 880729 5195032 10734543 a3cbcf vmlinux.o
> > $ size vmlinux.o
> > text data bss dec hex filename
> > 4658957 880729 5195032 10734718 a3cc7e vmlinux.o
> >
> > v6:
> > - no changes
> > v5:
> > - no changes
> > v4:
> > - move simple_xattrs_free() to fs/xattr.c
> > v3:
> > - in kmem_xattrs_free(), reinitialize the list
> > - use simple_xattr_* prefix
> > - introduce simple_xattr_add() to prevent direct list usage
> >
> > Cc: Li Zefan <lizefan@huawei.com>
> > Cc: Tejun Heo <tj@kernel.org>
> > Cc: Hugh Dickins <hughd@google.com>
>
> Hugh, can you please review and ack this one?

Yes, it looks nice to me. I might have preferred more as inlines in
the header file to lower the slight init/evict overhead, and I don't
see why __simple_xattr_set() isn't using simple_xattr_alloc() in the
same way that shmem_xattr_set() used shmem_xattr_alloc(). But none
of that matters:

Acked-by: Hugh Dickins <hughd@google.com>


\
 
 \ /
  Last update: 2012-08-20 10:01    [from the cache]
©2003-2011 Jasper Spaans