Messages in this thread Patch in this message | | | Date | Sun, 19 Aug 2012 11:49:58 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: [PATCH 1/5] drivers/net/wireless/ipw2x00/ipw2100.c: introduce missing initialization |
| |
From: Julia Lawall <Julia.Lawall@lip6.fr>
The result of one call to a function is tested, and then at the second call to the same function, the previous result, and not the current result, is tested again.
Also changed &bssid to bssid, at the suggestion of Stanislav Yakovlev.
The semantic match that finds the first problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ expression ret; identifier f; statement S1,S2; @@
*ret = f(...); if (\(ret != 0\|ret < 0\|ret == NULL\)) S1 ... when any *f(...); if (\(ret != 0\|ret < 0\|ret == NULL\)) S2 // </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
--- v2: changed &bssid to bssid
drivers/net/wireless/ipw2x00/ipw2100.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ipw2x00/ipw2100.c b/drivers/net/wireless/ipw2x00/ipw2100.c index 8a34202..534e655 100644 --- a/drivers/net/wireless/ipw2x00/ipw2100.c +++ b/drivers/net/wireless/ipw2x00/ipw2100.c @@ -2042,7 +2042,8 @@ static void isr_indicate_associated(struct ipw2100_priv *priv, u32 status) return; } len = ETH_ALEN; - ipw2100_get_ordinal(priv, IPW_ORD_STAT_ASSN_AP_BSSID, &bssid, &len); + ret = ipw2100_get_ordinal(priv, IPW_ORD_STAT_ASSN_AP_BSSID, bssid, + &len); if (ret) { IPW_DEBUG_INFO("failed querying ordinals at line %d\n", __LINE__);
| |