lkml.org 
[lkml]   [2012]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/14] drivers/power/ab8500_charger.c: fix error return code
    Date
    From: Julia Lawall <Julia.Lawall@lip6.fr>

    Initialize return variable before exiting on an error path.

    A simplified version of the semantic match that finds this problem is as
    follows: (http://coccinelle.lip6.fr/)

    // <smpl>
    (
    if@p1 (\(ret < 0\|ret != 0\))
    { ... return ret; }
    |
    ret@p1 = 0
    )
    ... when != ret = e1
    when != &ret
    *if(...)
    {
    ... when != ret = e2
    when forall
    return ret;
    }

    // </smpl>

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

    ---
    drivers/power/ab8500_charger.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/power/ab8500_charger.c b/drivers/power/ab8500_charger.c
    index d4f0c98..c2ef947 100644
    --- a/drivers/power/ab8500_charger.c
    +++ b/drivers/power/ab8500_charger.c
    @@ -2614,6 +2614,7 @@ static int __devinit ab8500_charger_probe(struct platform_device *pdev)
    create_singlethread_workqueue("ab8500_charger_wq");
    if (di->charger_wq == NULL) {
    dev_err(di->dev, "failed to create work queue\n");
    + ret = -ENOMEM;
    goto free_device_info;
    }



    \
     
     \ /
      Last update: 2012-08-19 11:21    [W:4.355 / U:0.992 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site