lkml.org 
[lkml]   [2012]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] perf: silence GTK2 probing errors
Date
Hi, David

On Sun, 19 Aug 2012 09:46:42 -0600, David Ahern wrote:
> If GTK2 development packages are not installed, make is rather noisy:
>
> $ make -C tools/perf O=/tmp/pbuild
> Package gtk+-2.0 was not found in the pkg-config search path.
> Perhaps you should add the directory containing `gtk+-2.0.pc'
> to the PKG_CONFIG_PATH environment variable
> No package 'gtk+-2.0' found
> make: Entering directory `/opt/sw/ahern/perf.git/tools/perf'
> Makefile:593: GTK2 not found, disables GTK2 support. Please install gtk2-devel or libgtk2.0-dev
> PERF_VERSION = 3.6.rc1.205.gdb146f.dirty
> make: Leaving directory `/opt/sw/ahern/perf.git/tools/perf'
> Package gtk+-2.0 was not found in the pkg-config search path.
> Perhaps you should add the directory containing `gtk+-2.0.pc'
> to the PKG_CONFIG_PATH environment variable
> No package 'gtk+-2.0' found
> make: Entering directory `/opt/sw/ahern/perf.git/tools/perf'
> Makefile:593: GTK2 not found, disables GTK2 support. Please install gtk2-devel or libgtk2.0-dev
> ...
>
> Silence the pkg-config errors. Aftewards:
>
> $ make -C tools/perf O=/tmp/pbuild
> make: Entering directory `/opt/sw/ahern/perf.git/tools/perf'
> Makefile:593: GTK2 not found, disables GTK2 support. Please install gtk2-devel or libgtk2.0-dev
> PERF_VERSION = 3.6.rc1.206.gd43ff9.dirty
> make: Leaving directory `/opt/sw/ahern/perf.git/tools/perf'
> make: Entering directory `/opt/sw/ahern/perf.git/tools/perf'
> Makefile:593: GTK2 not found, disables GTK2 support. Please install gtk2-devel or libgtk2.0-dev
> ...

The patch looks good to me. But I wonder why we see this "GTK2 not
found" message twice even in -j1 build. Perhaps we need to define the
NO_GTK2 after the feature-test.

Thanks,
Namhyung


>
> Signed-off-by: David Ahern <dsahern@gmail.com>
> Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> Cc: Pekka Enberg <penberg@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> ---
> tools/perf/Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index 1eb7f12..90cfecf 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -588,7 +588,7 @@ endif
> ifdef NO_GTK2
> BASIC_CFLAGS += -DNO_GTK2_SUPPORT
> else
> - FLAGS_GTK2=$(ALL_CFLAGS) $(ALL_LDFLAGS) $(EXTLIBS) $(shell pkg-config --libs --cflags gtk+-2.0)
> + FLAGS_GTK2=$(ALL_CFLAGS) $(ALL_LDFLAGS) $(EXTLIBS) $(shell pkg-config --libs --cflags gtk+-2.0 2>/dev/null)
> ifneq ($(call try-cc,$(SOURCE_GTK2),$(FLAGS_GTK2)),y)
> msg := $(warning GTK2 not found, disables GTK2 support. Please install gtk2-devel or libgtk2.0-dev);
> BASIC_CFLAGS += -DNO_GTK2_SUPPORT
> @@ -596,8 +596,8 @@ else
> ifeq ($(call try-cc,$(SOURCE_GTK2_INFOBAR),$(FLAGS_GTK2)),y)
> BASIC_CFLAGS += -DHAVE_GTK_INFO_BAR
> endif
> - BASIC_CFLAGS += $(shell pkg-config --cflags gtk+-2.0)
> - EXTLIBS += $(shell pkg-config --libs gtk+-2.0)
> + BASIC_CFLAGS += $(shell pkg-config --cflags gtk+-2.0 2>/dev/null)
> + EXTLIBS += $(shell pkg-config --libs gtk+-2.0 2>/dev/null)
> LIB_OBJS += $(OUTPUT)ui/gtk/browser.o
> LIB_OBJS += $(OUTPUT)ui/gtk/setup.o
> LIB_OBJS += $(OUTPUT)ui/gtk/util.o


\
 
 \ /
  Last update: 2012-08-20 05:01    [W:0.045 / U:0.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site