Messages in this thread | | | Date | Fri, 17 Aug 2012 09:27:44 +0200 | From | Borislav Petkov <> | Subject | Re: [RFC PATCH -v2 3/4] perf: Add persistent event facilities |
| |
On Thu, Aug 16, 2012 at 06:12:35PM -0400, Steven Rostedt wrote: > On Thu, 2012-08-16 at 19:45 +0200, Borislav Petkov wrote: > > > > -static void ring_buffer_put(struct ring_buffer *rb) > > +void ring_buffer_put(struct ring_buffer *rb) > > { > > struct perf_event *event, *n; > > unsigned long flags; > > I have to say that it is really unfortunate that we have two ring > buffers in the kernel, called struct ring_buffer. One being global and > one being local to events. And now we are exporting the name > "ring_buffer_*" too! This is going to confuse the hell out of people. > > Perhaps this should have been called perf_buffer, as that is what it's > used for.
Right, I guess the easiest would be to rename it for now.
-- Regards/Gruss, Boris.
Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551
| |