Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH V3 3/5] clk: mmp: add clock definition for pxa910 | Date | Thu, 16 Aug 2012 08:09:21 +0000 |
| |
On Thursday 16 August 2012, Chao Xie wrote: > >> + clocks[uart0_mux] = > >> + clk_register_mux(NULL, "uart0_mux", uart_parent, > >> + ARRAY_SIZE(uart_parent), CLK_SET_RATE_PARENT, > >> + apbc_base + APBC_UART0, 4, 3, 0, &clk_lock);
> i can change remove the clocks array, but even make the sentence > shorter, most of them still can not fit in one line.
Don't worry too much about the line length or a particular style. This is all about readability, and the style you use above may conform to some written style guide, but it's not the most readable one. If you reformat it to
clk = clk_register_mux(NULL, "uart0_mux", uart_parent, ARRAY_SIZE(uart_parent), CLK_SET_RATE_PARENT, apbc_base + APBC_UART0, 4, 3, 0, &clk_lock);
or
clk = clk_register_mux(NULL, "uart0_mux", uart_parent, ARRAY_SIZE(uart_parent), CLK_SET_RATE_PARENT, apbc_base + APBC_UART0, 4, 3, 0, &clk_lock);
or
clk = clk_register_mux(NULL, "uart0_mux", uart_parent, ARRAY_SIZE(uart_parent), CLK_SET_RATE_PARENT, apbc_base + APBC_UART0, 4, 3, 0, &clk_lock);
I still find that more readable.
Arnd
| |