lkml.org 
[lkml]   [2012]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC PATCH -v2 3/4] perf: Add persistent event facilities
    From
    Date
    On Thu, 2012-08-16 at 19:45 +0200, Borislav Petkov wrote:
    >
    > -static void ring_buffer_put(struct ring_buffer *rb)
    > +void ring_buffer_put(struct ring_buffer *rb)
    > {
    > struct perf_event *event, *n;
    > unsigned long flags;

    I have to say that it is really unfortunate that we have two ring
    buffers in the kernel, called struct ring_buffer. One being global and
    one being local to events. And now we are exporting the name
    "ring_buffer_*" too! This is going to confuse the hell out of people.

    Perhaps this should have been called perf_buffer, as that is what it's
    used for.

    -- Steve




    \
     
     \ /
      Last update: 2012-08-17 00:41    [W:4.707 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site