Messages in this thread | | | Date | Thu, 16 Aug 2012 14:55:01 -0700 (PDT) | Subject | Re: [net V2] act_mirred: do not drop packets when fails to mirror it | From | David Miller <> |
| |
From: Jamal Hadi Salim <jhs@mojatatu.com> Date: Thu, 16 Aug 2012 08:11:47 -0400
> On Thu, 2012-08-16 at 14:44 +0800, Jason Wang wrote: >> We drop packet unconditionally when we fail to mirror it. This is not intended >> in some cases. Consdier for kvm guest, we may mirror the traffic of the bridge >> to a tap device used by a VM. When kernel fails to mirror the packet in >> conditions such as when qemu crashes or stop polling the tap, it's hard for the >> management software to detect such condition and clean the the mirroring >> before. This would lead all packets to the bridge to be dropped and break the >> netowrk of other virtual machines. >> >> To solve the issue, the patch does not drop packets when kernel fails to mirror >> it, and only drop the redirected packets. >> >> Signed-off-by: Jason Wang <jasowang@redhat.com> > > Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
Applied, thanks.
| |