Messages in this thread | | | Date | Thu, 16 Aug 2012 15:19:09 -0400 | From | Theodore Ts'o <> | Subject | Re: [PATCH 3/8] ext3: remove lock/unlock super |
| |
On Thu, Aug 16, 2012 at 06:39:04PM +0200, Jan Kara wrote: > On Thu 16-08-12 12:00:26, Marco Stornelli wrote: > > From: Marco Stornelli <marco.stornelli@gmail.com> > > > > Replaced lock and unlock super with a new fs mutex s_lock. > Hum, is the lock needed at all? Remount & unfreeze both run with s_umount > held for writing. Thus we already have exclusion between these two calls. > The same seems to hold for ext4 BTW.
Agreed, it's not clear lock_super() is needed at all for ext4 at this point.
- Ted
| |