Messages in this thread | | | From | Michal Nazarewicz <> | Subject | Re: [RFC 2/2] cma: support MIGRATE_DISCARD | Date | Thu, 16 Aug 2012 15:17:40 +0200 |
| |
> On Tue, Aug 14, 2012 at 04:19:55PM +0200, Michal Nazarewicz wrote: >> Since CMA is the only user of MIGRATE_DISCARD it may be worth it to >> guard it inside an #ifdef, eg:
Minchan Kim <minchan@kernel.org> writes: > In summary, I want to open it for potential usecases in future if anyone > doesn't oppose strongly.
Fair enough.
>>> if (!trylock_page(page)) { >>> - if (!force || mode == MIGRATE_ASYNC) >>> + if (!force || mode & MIGRATE_ASYNC)
> It's not wrong technically but for readability, NP.
Yep, that was my point, thanks. :)
-- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--[unhandled content-type:application/pgp-signature] | |