lkml.org 
[lkml]   [2012]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 3/8] procfs: Add ability to plug in auxiliary fdinfo providers
On Wed, Aug 15, 2012 at 01:21:19PM +0400, Cyrill Gorcunov wrote:
> struct proc_fdinfo {
> - loff_t f_pos;
> - int f_flags;
> + struct file *f_file;
> + int f_flags;
> };

> + struct proc_fdinfo *fdinfo;
> + struct seq_file *m;
> + int ret;
>
> fdinfo = kzalloc(sizeof(*fdinfo), GFP_KERNEL);
> if (!fdinfo)
> return -ENOMEM;

> + ret = single_open(file, seq_show, fdinfo);
> + if (ret) {
> + put_filp(fdinfo->f_file);
> + goto err_free;
> }
>
> + m = file->private_data;
> + m->private = fdinfo;

This, BTW, is too convoluted for its own good. What you need is
something like
struct whatever {
struct seq_file *m;
struct file *f;
int flags;
};
with single allocation of that sucker in your ->open(). Set
file->private_data to address of seq_file field in your object *before*
calling seq_open() and don't bother with m->private at all - just use
container_of(m, struct whatever, m) in your ->show() to get to that
structure...


\
 
 \ /
  Last update: 2012-08-16 00:23    [W:0.188 / U:0.836 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site