lkml.org 
[lkml]   [2012]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[v2.6.34-stable 031/165] powerpc/pci: Check devices status property when scanning OF tree
    Date
    From: Sonny Rao <sonnyrao@us.ibm.com>

    -------------------
    This is a commit scheduled for the next v2.6.34 longterm release.
    http://git.kernel.org/?p=linux/kernel/git/paulg/longterm-queue-2.6.34.git
    If you see a problem with using this for longterm, please comment.
    -------------------

    commit 5b339bdf164d8aee394609768f7e2e4415b0252a upstream.

    We ran into an issue where it looks like we're not properly ignoring a
    pci device with a non-good status property when we walk the device tree
    and instanciate the Linux side PCI devices.

    However, the EEH init code does look for the property and disables EEH
    on these devices. This leaves us in an inconsistent where we are poking
    at a supposedly bad piece of hardware and RTAS will block our config
    cycles because EEH isn't enabled anyway.

    Signed-of-by: Sonny Rao <sonnyrao@linux.vnet.ibm.com>

    Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    ---
    arch/powerpc/kernel/pci_of_scan.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/arch/powerpc/kernel/pci_of_scan.c b/arch/powerpc/kernel/pci_of_scan.c
    index cd11d5c..6ddb795f 100644
    --- a/arch/powerpc/kernel/pci_of_scan.c
    +++ b/arch/powerpc/kernel/pci_of_scan.c
    @@ -310,6 +310,8 @@ static void __devinit __of_scan_bus(struct device_node *node,
    /* Scan direct children */
    for_each_child_of_node(node, child) {
    pr_debug(" * %s\n", child->full_name);
    + if (!of_device_is_available(child))
    + continue;
    reg = of_get_property(child, "reg", &reglen);
    if (reg == NULL || reglen < 20)
    continue;
    --
    1.7.12.rc2


    \
     
     \ /
      Last update: 2012-08-15 23:22    [W:3.843 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site