Messages in this thread | | | Date | Wed, 15 Aug 2012 22:12:33 +0800 | From | Fengguang Wu <> | Subject | Re: [PATCH] select GENERIC_ATOMIC64 for c6x/score/unicore32 archs |
| |
On Wed, Aug 15, 2012 at 09:42:58AM -0400, Mark Salter wrote: > On Wed, 2012-08-15 at 10:36 +0800, Fengguang Wu wrote: > > > -#define L1_CACHE_BYTES L2_CACHE_BYTES > > > +#define L1_CACHE_SHIFT L2_CACHE_SHIFT > > > +#define L1_CACHE_BYTES (1 << L2_CACHE_SHIFT) > > > > Nitpick: the last line could better be: > > > > +#define L1_CACHE_BYTES (1 << L1_CACHE_SHIFT) > > > > Reviewed-by: Fengguang Wu <fengguang.wu@intel.com> > > Yes, I noticed that after sending the patch. > > Should I push this through the c6x tree?
That'd be good. For consistency, will you also include the GENERIC_ATOMIC64 chunk in the titled patch?
I can send Andrew an updated series (reducing the c6x changes, and possibly the score/unicore32 bits) later on.
Thanks, Fengguang
| |