lkml.org 
[lkml]   [2012]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2 1/2] drivers/mfd: Add realtek pcie card reader driver
    Date
    On Tuesday 14 August 2012, wei_wang@realsil.com.cn wrote:
    > +
    > +void rtsx_pci_start_run(struct rtsx_pcr *pcr)
    > +{
    > + /* If pci device removed, don't queue idle work any more */
    > + if (pcr->remove_pci)
    > + return;
    > +
    > + if (pcr->state != PDEV_STAT_RUN) {
    > + pcr->state = PDEV_STAT_RUN;
    > + pcr->ops->enable_auto_blink(pcr);
    > + }
    > +
    > + mod_timer(&pcr->idle_timer, jiffies + msecs_to_jiffies(200));
    > +}
    > +EXPORT_SYMBOL_GPL(rtsx_pci_start_run);

    One more comment on the mod_timer/queue_work combination: I just saw that
    Tejun Heo posted a series to introduce a new mod_delayed_work() helper.

    Once that goes in, it would be best to start using it here.

    Arnd


    \
     
     \ /
      Last update: 2012-08-15 09:23    [W:2.700 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site